This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Fix a crash on macOS 10.11. #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `delegate` and `dataSource` are `assign` (not`weak`) on macOS 10.11. - `dataSource` was set to `nil` before `delegate`, and when `dataSource` is changed `NSTableView` notifies the `delegate` about removing all rows. - alexrozanski#58 introduced an issue where `_delegateDataSourceProxy` was released before setting `delegate` and `dataSource` to `nil`. - When `NSTableView` attempted to notify the `delegate` about removing all rows it was already released, which caused crashes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delegateanddataSourceareassign(notweak) on macOS 10.11.dataSourcewas set tonilbeforedelegate, and whendataSourceis changedNSTableViewnotifies thedelegateabout removing all rows._delegateDataSourceProxywas released before settingdelegateanddataSourcetonil.NSTableViewattempted to notify thedelegateabout removing all rows it was already released, which caused crashes.