Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Locations frontend in create form and league list view #25

Merged
merged 13 commits into from
Aug 1, 2023
Merged

feat(frontend): Locations frontend in create form and league list view #25

merged 13 commits into from
Aug 1, 2023

Conversation

alexstojda
Copy link
Owner

@alexstojda alexstojda commented Jul 31, 2023 •
edited
Loading

  • chore(frontend): installed chakra-react-select
  • feat(leagues): Update league API to use Locations
  • fix(api): Panic if controller is missing from API
  • fix(locations-api): Fix error checking logic in location api controller
  • fix(leagues-api): Fix UUIDs in list response
  • feat(leagues-frontend): Use locations API when creating a league
  • feat(leagues-api): Include location object in league response instead of just location ID
  • feat(leagues-frontend): Show Location name & address on list page
  • refactor(leagues-frontend): Move LocationSelect to standalone component
  • tests(leagues-frontend): Update tests for Form and new LocationSelect component

closes #23

@alexstojda
chore(frontend): installed chakra-react-select
b5d17c3
@alexstojda
feat(leagues): Update league API to use Locations
930230a
@alexstojda
fix(api): Panic if controller is missing from API
8a66d02
@alexstojda
fix(locations-api): Fix error checking logic in location api controller
eac8d82
@alexstojda
fix(leagues-api): Fix UUIDs in list response
17bf880
@alexstojda
feat(leagues-frontend): Use locations API when creating a league
380b35a 
- Select the location for a league from a select
- Lists all locations from pinman and filtered locations from Pinball Map, with any options already known to pinman removed from the list
@alexstojda
feat(leagues-api): Include location object in league response instead…
0295496 
… of just location ID
@alexstojda
feat(leagues-frontend): Show Location name & address on list page
677c8ce
@alexstojda
refactor(leagues-frontend): Move LocationSelect to standalone component
4c135e6
@alexstojda
tests(leagues-frontend): Update tests for Form and new LocationSelect…
a64244e 
… component
@alexstojda
chore(leagues-frontend): Fix code smells
c7699a4
@alexstojda alexstojda force-pushed the feat/league-set-location-frontend branch from 9282c94 to c7699a4 Compare July 31, 2023 23:36
@alexstojda alexstojda changed the title feat(frontend): Select location in create league form feat(frontend): Locations frontend in create form and league list view Aug 1, 2023
@alexstojda alexstojda force-pushed the feat/league-set-location-frontend branch from 0a8e68a to 08fa1e1 Compare August 1, 2023 02:14
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@alexstojda alexstojda marked this pull request as ready for review August 1, 2023 02:20
@alexstojda alexstojda merged commit 7d18928 into main Aug 1, 2023
7 checks passed
@alexstojda alexstojda deleted the feat/league-set-location-frontend branch August 1, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As the league owner, I can set the leagues location when creating a league
1 participant
@alexstojda