Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed redundant application declaration #225

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

itoxiq
Copy link
Contributor

@itoxiq itoxiq commented Mar 15, 2024

There is no need to declare proper and libgraph in applications because they will be derived via deps automatically.
Currently you will also get the following warning when compiling propcheck.

both :extra_applications and :applications was found in your mix.exs. You most likely want to remove the :applications key, as all applications are derived from your dependencies

@evnu
Copy link
Collaborator

evnu commented Mar 15, 2024

Thanks! @alfert don't know if this warrants a Patch release to make the warning go away for users.

@evnu evnu merged commit 8424594 into alfert:master Mar 15, 2024
5 checks passed
@alfert
Copy link
Owner

alfert commented Mar 16, 2024

Let's do a patch release, feels like a nice service for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants