Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hreq fails to build on stable rust 1.46.0 #11

Closed
algesten opened this issue Aug 29, 2020 · 1 comment
Closed

hreq fails to build on stable rust 1.46.0 #11

algesten opened this issue Aug 29, 2020 · 1 comment

Comments

@algesten
Copy link
Owner

error: reached the type-length limit while instantiating `<std::boxed::Box<std::future::fr..., ()}]>>, ()}]>, ()}]>>>>>::into`
   --> /Users/martin/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore/convert/mod.rs:559:5
    |
559 | /     fn into(self) -> U {
560 | |         U::from(self)
561 | |     }
    | |_____^
    |
    = note: consider adding a `#![type_length_limit="1527629"]` attribute to your crate

The problem seems to be due to using tracing::instrument of async blocks.

Related:

rust-lang/rust#75992
rust-lang/rust#54540 (comment)
tokio-rs/tracing#616

@algesten
Copy link
Owner Author

algesten commented Aug 29, 2020


Regression in 0a49057dd35d9bd2fcc9760a054809c30eee2a58


searched nightlies: from nightly-2020-08-12 to nightly-2020-08-15
regressed nightly: nightly-2020-08-14
searched commits: from rust-lang/rust@576d27c to rust-lang/rust@81dc88f
regressed commit: rust-lang/rust@0a49057

bisected with cargo-bisect-rustc v0.5.2

Host triple: x86_64-apple-darwin
Reproduce with:

cargo bisect-rustc --start=2020-08-12 --end=2020-08-15 

algesten added a commit to algesten/hreq-h1 that referenced this issue Aug 29, 2020
Rust 1.46.0 gives us trouble with too large types. Go back to log
crate until this is resolved.

Related:

algesten/hreq#11
tokio-rs/tracing#616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant