Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rules): automatic facet filter deserialization #753

Merged
merged 4 commits into from
Aug 20, 2021
Merged

fix(rules): automatic facet filter deserialization #753

merged 4 commits into from
Aug 20, 2021

Conversation

aallam
Copy link
Member

@aallam aallam commented Aug 20, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue n/a
Need Doc update yes/no

Describe your change

Deserialize AutomaticFacetFilterDeserializer when it has only facet param.

@aallam aallam requested a review from Ant-hem August 20, 2021 08:13
Ant-hem
Ant-hem reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@Ant-hem Ant-hem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add another test case and we are good to go :)

...ore/src/test/java/com/algolia/search/serialization/TestAutomaticFacetFilterDeserializer.java Show resolved Hide resolved
@aallam aallam merged commit c3647a9 into master Aug 20, 2021
@aallam aallam deleted the fix/automaticFacetFilter branch August 20, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ant-hem Ant-hem Ant-hem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aallam @Ant-hem