fix(recommend): remove unused trendingFacets props #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojva
reviewed
Dec 15, 2022
.gitignore
Outdated
| @@ -6,3 +6,5 @@ dist | |||
| *.umd.js | |||
| yarn-error.log | |||
| .env | |||
|
|
|||
| .idea/ | |||
There was a problem hiding this comment.
it probably should just be reverted actually, local files should be in a global gitignore
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e3e3692:
|
Haroenv
reviewed
Dec 15, 2022
.gitignore
Outdated
| @@ -6,3 +6,5 @@ dist | |||
| *.umd.js | |||
| yarn-error.log | |||
| .env | |||
|
|
|||
| .idea/ | |||
There was a problem hiding this comment.
it probably should just be reverted actually, local files should be in a global gitignore
| export type TrendingFacetsQuery = Omit<TrendingQuery, 'model' | 'facetValue'>; | ||
| export type TrendingFacetsQuery = Omit< | ||
| TrendingQuery, | ||
| 'model' | 'facetValue' | 'fallbackParameters' | 'queryParameters' |
There was a problem hiding this comment.
At this point why have a shared TrendingQuery type if they differ so much?
According to the API endpoints:
- Trending facets
facetName: required
- Trending items
facetName: optionalfacetValue: optional
There was a problem hiding this comment.
yeah, i wanted to do that in a separate PR, both for client and for the libs
jojva
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
fallbackParametersandqueryParametersgiven that the recommend API does not support these props.🐛 : JIRA