Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): expose rule.consequence.promote.objectIDs string array #195

Merged
merged 3 commits into from
Jun 2, 2020
Merged

feat(rule): expose rule.consequence.promote.objectIDs string array #195

merged 3 commits into from
Jun 2, 2020

Conversation

aallam
Copy link
Member

@aallam aallam commented Jun 2, 2020

Closes #191

@aallam aallam requested a review from spinach as a code owner June 2, 2020 09:49
spinach
spinach approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@spinach spinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look clean and respects good DX, LGTM 👌

@aallam aallam merged commit 8642701 into develop Jun 2, 2020
@aallam aallam deleted the feat/rule branch June 2, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinach spinach spinach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose rule.consequence.promote.objectIDs string array
2 participants
@aallam @spinach