fix(ua): change the User-Agent to use the new specs lib (version)

[robertmogos]

Summary
Update UA to angular ($VERSION); angular-instantsearch ($VERSION)

Add the addAlgoliaAgent to SearchClient and fix the issue where the UA is only added when the SearchClient is not passed in config

Result

[francoischalifour]

This will also need some tests.

[algobot]

Deploy preview for angular-instantsearch ready!

Built with commit be8e039

https://deploy-preview-481--angular-instantsearch.netlify.com

[algobot]

Deploy preview for angular-instantsearch ready!

Built with commit 046be61

https://deploy-preview-481--angular-instantsearch.netlify.com

[algobot]

Deploy preview for angular-instantsearch ready!

Built with commit 2fc3318

https://deploy-preview-481--angular-instantsearch.netlify.com

[francoischalifour]

Before approving, this should be tested for both client and server versions.

[robertmogos]

Before approving, this should be tested for both client and server versions.

@francoischalifour Tested both on client and server:

Netlify:
angular (7.0.1);angular-instantsearch (2.2.1)

SSR:
angular-instantsearch (2.2.1);angular-instantsearch-server (2.2.1);

[Haroenv]

looks like SSR is missing the Angular version then?

[robertmogos]

looks like SSR is missing the Angular version then?

@Haroenv I didn't added it since in create-ssr-algolia-client.ts there is no import related to Angular. Should I add it ?

import * as algoliasearchProxy from 'algoliasearch/index';
import * as encodeProxy from 'querystring-es3/encode';
import { VERSION } from './version';

[Haroenv]

It would seem useful to know for me:

import {
   VERSION as AngularVersion,
 } from '@angular/core';

[Haroenv]

Looks like prettier wants the imports inlined. Also there are no tests for this, and they probably should be added

[tkrugg]

Looks ready to merge 💯
Please refrain from merging if you can't release this yet, just so we don't block other feature.

[francoischalifour]

It doesn't seem to have a test for the client side.

[robertmogos]

It doesn't seem to have a test for the client side.

I added the client side UA + thanks to @tkrugg we spot a bug where the UA was only added when the SearchClient was not provided in the config. I added too the addAlgoliaAgent: (agent: string) => void; method to the SearchClient

Feedback applied.