fix(specs): fix missing params and types

algolia · Jul 4, 2022 · 48cd2a1 · 48cd2a1
1 parent d358fdf
commit 48cd2a1
Show file tree

Hide file tree

Showing 14 changed files with 974 additions and 387 deletions.
diff --git a/clients/algoliasearch-client-php/lib/Model/Search/SchemasQuery.php b/clients/algoliasearch-client-php/lib/Model/Search/SchemasQuery.php
diff --git a/generators/src/main/java/com/algolia/codegen/cts/manager/JavaCTSManager.java b/generators/src/main/java/com/algolia/codegen/cts/manager/JavaCTSManager.java
@@ -15,7 +15,7 @@ public JavaCTSManager(String client) {
 
   @Override
   public void addSupportingFiles(List<SupportingFile> supportingFiles) {
-    supportingFiles.add(new SupportingFile("build.mustache", ".", "build.gradle"));
+    supportingFiles.add(new SupportingFile("build.mustache", "", "build.gradle"));
   }
 
   @Override

diff --git a/generators/src/main/java/com/algolia/codegen/cts/tests/ParametersWithDataType.java b/generators/src/main/java/com/algolia/codegen/cts/tests/ParametersWithDataType.java
@@ -305,7 +305,13 @@ private void handleModel(
       }
       if (varSpec == null) {
         throw new CTSException(
-          "Parameter " + entry.getKey() + " not found in " + paramName + ". You might have a type conflict in the spec for " + baseType
+          "Parameter '" +
+          entry.getKey() +
+          "' not found in '" +
+          paramName +
+          "'. You might have a type conflict in the spec for '" +
+          baseType +
+          "'"
         );
       }
 

diff --git a/specs/abtesting/common/parameters.yml b/specs/abtesting/common/parameters.yml
@@ -22,7 +22,11 @@ endAt:
 
 createdAt:
   type: string
-  description: End date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
+  description: Create date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
+
+updatedAt:
+  type: string
+  description: Update date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
 
 name:
   type: string

diff --git a/specs/abtesting/common/schemas/ABTest.yml b/specs/abtesting/common/schemas/ABTest.yml
@@ -20,6 +20,8 @@ ABTest:
       description: A/B test significance based on conversion data. Should be > 0.95 to be considered significant (no matter which variant is winning).
     endAt:
       $ref: '../parameters.yml#/endAt'
+    updatedAt:
+      $ref: '../parameters.yml#/updatedAt'
     createdAt:
       $ref: '../parameters.yml#/createdAt'
     name:
@@ -34,6 +36,7 @@ ABTest:
     - name
     - createdAt
     - endAt
+    - updatedAt
     - conversionSignificance
     - clickSignificance
     - abTestID