Merge branch 'main' into fix/recommend

clients/algoliasearch-client-csharp/algoliasearch/Models/Recommend/GetRecommendationsResponse.cs

@@ -19,8 +19,15 @@ public partial class GetRecommendationsResponse
   /// <summary>
   /// Initializes a new instance of the GetRecommendationsResponse class.
   /// </summary>
-  public GetRecommendationsResponse()
+  [JsonConstructor]
+  public GetRecommendationsResponse() { }
+  /// <summary>
+  /// Initializes a new instance of the GetRecommendationsResponse class.
+  /// </summary>
+  /// <param name="results">results (required).</param>
+  public GetRecommendationsResponse(List<RecommendationsResults> results)
   {
+    Results = results ?? throw new ArgumentNullException(nameof(results));
   }
 
   /// <summary>

clients/algoliasearch-client-dart/packages/algoliasearch/lib/src/model/get_recommendations_response.dart

@@ -10,11 +10,11 @@ part 'get_recommendations_response.g.dart';
 final class GetRecommendationsResponse {
   /// Returns a new [GetRecommendationsResponse] instance.
   const GetRecommendationsResponse({
-    this.results,
+    required this.results,
   });
 
   @JsonKey(name: r'results')
-  final List<RecommendationsResults>? results;
+  final List<RecommendationsResults> results;
 
   @override
   bool operator ==(Object other) =>

clients/algoliasearch-client-dart/packages/client_recommend/example/example.dart

@@ -40,10 +40,6 @@ void main() async {
 /// Prints the search hits.
 void printRecommendations(GetRecommendationsResponse response) {
   final results = response.results;
-  if (results == null) {
-    print("No recommendations found");
-    return;
-  }
 
   // Loop over each result and map over the search hits,
   // converting each hit to a product.

clients/algoliasearch-client-dart/packages/client_recommend/lib/src/model/get_recommendations_response.dart

@@ -10,11 +10,11 @@ part 'get_recommendations_response.g.dart';
 final class GetRecommendationsResponse {
   /// Returns a new [GetRecommendationsResponse] instance.
   const GetRecommendationsResponse({
-    this.results,
+    required this.results,
   });
 
   @JsonKey(name: r'results')
-  final List<RecommendationsResults>? results;
+  final List<RecommendationsResults> results;
 
   @override
   bool operator ==(Object other) =>

clients/algoliasearch-client-java/algoliasearch/src/main/java/com/algolia/model/recommend/GetRecommendationsResponse.java

@@ -13,23 +13,20 @@
 public class GetRecommendationsResponse {
 
   @JsonProperty("results")
-  private List<RecommendationsResults> results;
+  private List<RecommendationsResults> results = new ArrayList<>();
 
   public GetRecommendationsResponse setResults(List<RecommendationsResults> results) {
     this.results = results;
     return this;
   }
 
   public GetRecommendationsResponse addResults(RecommendationsResults resultsItem) {
-    if (this.results == null) {
-      this.results = new ArrayList<>();
-    }
     this.results.add(resultsItem);
     return this;
   }
 
   /** Get results */
-  @javax.annotation.Nullable
+  @javax.annotation.Nonnull
   public List<RecommendationsResults> getResults() {
     return results;
   }

clients/algoliasearch-client-javascript/packages/algoliasearch/lite/model/getRecommendationsResponse.ts

@@ -3,5 +3,5 @@
 import type { RecommendationsResults } from './recommendationsResults';
 
 export type GetRecommendationsResponse = {
-  results?: RecommendationsResults[];
+  results: RecommendationsResults[];
 };

clients/algoliasearch-client-javascript/packages/recommend/model/getRecommendationsResponse.ts

@@ -3,5 +3,5 @@
 import type { RecommendationsResults } from './recommendationsResults';
 
 export type GetRecommendationsResponse = {
-  results?: RecommendationsResults[];
+  results: RecommendationsResults[];
 };

clients/algoliasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/model/recommend/GetRecommendationsResponse.kt

@@ -12,5 +12,5 @@ import kotlinx.serialization.json.*
 @Serializable
 public data class GetRecommendationsResponse(
 
-  @SerialName(value = "results") val results: List<RecommendationsResults>? = null,
+  @SerialName(value = "results") val results: List<RecommendationsResults>,
 )

clients/algoliasearch-client-php/lib/Model/Recommend/GetRecommendationsResponse.php

@@ -136,7 +136,13 @@ public static function getters()
      */
     public function listInvalidProperties()
     {
-        return [];
+        $invalidProperties = [];
+
+        if (!isset($this->container['results']) || null === $this->container['results']) {
+            $invalidProperties[] = "'results' can't be null";
+        }
+
+        return $invalidProperties;
     }
 
     /**
@@ -153,7 +159,7 @@ public function valid()
     /**
      * Gets results.
      *
-     * @return null|\Algolia\AlgoliaSearch\Model\Recommend\RecommendationsResults[]
+     * @return \Algolia\AlgoliaSearch\Model\Recommend\RecommendationsResults[]
      */
     public function getResults()
     {
@@ -163,7 +169,7 @@ public function getResults()
     /**
      * Sets results.
      *
-     * @param null|\Algolia\AlgoliaSearch\Model\Recommend\RecommendationsResults[] $results results
+     * @param \Algolia\AlgoliaSearch\Model\Recommend\RecommendationsResults[] $results results
      *
      * @return self
      */

clients/algoliasearch-client-python/algoliasearch/recommend/models/get_recommendations_response.py

@@ -7,7 +7,7 @@
 from __future__ import annotations
 
 from json import loads
-from typing import Any, Dict, List, Optional, Self
+from typing import Any, Dict, List, Self
 
 from pydantic import BaseModel, ConfigDict
 
@@ -21,7 +21,7 @@ class GetRecommendationsResponse(BaseModel):
     GetRecommendationsResponse
     """
 
-    results: Optional[List[RecommendationsResults]] = None
+    results: List[RecommendationsResults]
 
     model_config = ConfigDict(
         use_enum_values=True, populate_by_name=True, validate_assignment=True

clients/algoliasearch-client-ruby/lib/algolia/models/recommend/get_recommendations_response.rb

@@ -61,6 +61,8 @@ def initialize(attributes = {})
           if (value = attributes[:results]).is_a?(Array)
             self.results = value
           end
+        else
+          self.results = nil
         end
       end
 

clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/GetRecommendationsResponse.scala

@@ -32,5 +32,5 @@ package algoliasearch.recommend
 /** GetRecommendationsResponse
   */
 case class GetRecommendationsResponse(
-    results: Option[Seq[RecommendationsResults]] = scala.None
+    results: Seq[RecommendationsResults]
 )

clients/algoliasearch-client-swift/Sources/Recommend/Models/GetRecommendationsResponse.swift

@@ -7,9 +7,9 @@ import Foundation
 #endif
 
 public struct GetRecommendationsResponse: Codable, JSONEncodable {
-    public var results: [RecommendationsResults]?
+    public var results: [RecommendationsResults]
 
-    public init(results: [RecommendationsResults]? = nil) {
+    public init(results: [RecommendationsResults]) {
         self.results = results
     }
 
@@ -21,7 +21,7 @@ public struct GetRecommendationsResponse: Codable, JSONEncodable {
 
     public func encode(to encoder: Encoder) throws {
         var container = encoder.container(keyedBy: CodingKeys.self)
-        try container.encodeIfPresent(self.results, forKey: .results)
+        try container.encode(self.results, forKey: .results)
     }
 }
 
@@ -33,6 +33,6 @@ extension GetRecommendationsResponse: Equatable {
 
 extension GetRecommendationsResponse: Hashable {
     public func hash(into hasher: inout Hasher) {
-        hasher.combine(self.results?.hashValue)
+        hasher.combine(self.results.hashValue)
     }
 }

scripts/cts/runCts.ts

@@ -23,7 +23,12 @@ async function runCtsOne(
     const e2eFolder = toAbsolutePath(
       `tests/output/${language}/${getTestOutputFolder(language)}/e2e`,
     );
-    if ((await exists(e2eFolder)) && (await fsp.readdir(e2eFolder)).length > 0) folders.push('e2e');
+    if (
+      (await exists(e2eFolder)) &&
+      (await fsp.readdir(e2eFolder)).filter((f) => f !== '__init__.py' && f !== '__pycache__')
+        .length > 0
+    )
+      folders.push('e2e');
   }
   if (!excludeUnit) {
     folders.push('client', 'requests');

specs/bundled/algoliasearch.yml

@@ -413,6 +413,8 @@ paths:
                     type: array
                     items:
                       $ref: '#/components/schemas/recommendationsResults'
+                required:
+                  - results
         '400':
           $ref: '#/components/responses/BadRequest'
         '402':

specs/bundled/recommend.doc.yml

@@ -1020,6 +1020,8 @@ paths:
                     type: array
                     items:
                       $ref: '#/components/schemas/recommendationsResults'
+                required:
+                  - results
         '400':
           $ref: '#/components/responses/BadRequest'
         '402':

specs/bundled/recommend.yml

@@ -302,6 +302,8 @@ paths:
                     type: array
                     items:
                       $ref: '#/components/schemas/recommendationsResults'
+                required:
+                  - results
         '400':
           $ref: '#/components/responses/BadRequest'
         '402':

specs/recommend/paths/getRecommendations.yml

@@ -41,6 +41,8 @@ post:
                 type: array
                 items:
                   $ref: '../common/schemas/RecommendationsResponse.yml#/recommendationsResults'
+            required:
+              - results
     '400':
       $ref: '../../common/responses/BadRequest.yml'
     '402':