feat(specs): update predict client API URL #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Sep 12, 2022
specs/predict/spec.yml
Outdated
| @@ -10,17 +10,17 @@ components: | |||
| apiKey: | |||
| $ref: '../common/securitySchemes.yml#/apiKey' | |||
| servers: | |||
| - url: https://predict-api-432xa6wemq-{region}.a.run.app | |||
| - url: https://predict-{region}.algolia | |||
There was a problem hiding this comment.
I believe it should end with .com (see other spec.yml files for example)
There was a problem hiding this comment.
Not sure how the old URL worked!
Resolved in 1863ee3
specs/predict/spec.yml
Outdated
Comment on lines
17
to
19
| - us | ||
| - eu | ||
| default: eu |
There was a problem hiding this comment.
The tests should be updated with the region change https://github.com/algolia/api-clients-automation/blob/main/tests/CTS/client/predict/parameters.json#L14
shortcuts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: PRED-560
Related PR: https://github.com/algolia/doc/pull/7336
Changes included:
🧪 Test
New URL should be https://predict.us.algolia.com/ or https://predict.eu.algolia.com/ depending on region.