-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): CTS APIC-253 #102
Conversation
0cc9690
to
e663511
Compare
e663511
to
12c7a6d
Compare
@@ -2,7 +2,11 @@ | |||
{ | |||
"method": "addApiKey", | |||
"parameters": { | |||
"acl": ["search", "addObject"], | |||
"$objectName": "ApiKey", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a short section in our README or wherever about $objectName
, and some other $...
stuff?
I guess it's used in generating java client, but for languages like JavaScript will not use it, and people like me will have trouble writing this json spec in the future if the information isn't there.
Anyway it's not necessarily relevant to this PR. So it's not blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit documented in CTS.md
but not $enumType
, I'll add it.
The enum is present in the spec so it's 1:1 between the test and the spec, nothing particular for js or java.
I just saw you marked it as draft. So dismissing my approval for now. Is there more to do? |
Yes I have a issue with maven not running tests on the CI: I can't find info about this error and can't reproduce locally, it might be because of limited storage on the CI or something more complicated. I'm investigating it but I feel like I'm loosing a lot of time with maven for development so I'm considering switching to gradle before it's too late, so this PR is postponed. |
🧭 What and Why
🎟 JIRA Ticket: APIC-253
Generate the CTS for Java, using the parameters with data type to generate all objects recursively. The naming is kind of ugly but the tests are functional.
Also test searchParams.
Changes included:
$objectName
and$enumType
to search ctsJSONAssert
to check if the body contains the same set of properties as the CTS (it will also contains all the default, that we still need to check)🧪 Test
yarn docker cts:generate
yarn docker cts:test