Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): prefix Predict predictions success types #1032

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

francoischalifour
Copy link
Member

🧭 What and Why

This fixes an inconsistency in our types: it adds the predictions prefix to the predictions success responses.

You can see the exported types on Paka.

Changes included:

  • Prefix predictions success types with predictions

🧪 Test

None added.

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4828aca
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6329823193d5ae0009b74014
😎 Deploy Preview https://deploy-preview-1032--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@francoischalifour francoischalifour changed the title fix(predict): prefix predictions success types fix(javascript): prefix predictions success types Sep 20, 2022
@francoischalifour francoischalifour changed the title fix(javascript): prefix predictions success types fix(javascript): prefix Predict predictions success types Sep 20, 2022
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 20, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts changed the title fix(javascript): prefix Predict predictions success types fix(specs): prefix Predict predictions success types Sep 20, 2022
@shortcuts shortcuts merged commit b56b2b4 into main Sep 20, 2022
@shortcuts shortcuts deleted the fix/predict-predictions-prefix branch September 20, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants