feat(php): Add remaining php clients #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
changed the title
millotp
approved these changes
Jan 27, 2022
clients/algoliasearch-client-php/lib/Configuration/InsightsConfig.php
Outdated
Show resolved
Hide resolved
| @@ -60,6 +60,14 @@ class Configuration extends AbstractConfig | |||
| */ | |||
| protected $tempFolderPath; | |||
There was a problem hiding this comment.
You can remove this as we won't deal with file download
There was a problem hiding this comment.
The method getTempFolderPath() is used in the ObjectSerializer class (in the deserialize() method)
millotp
reviewed
Jan 31, 2022
clients/algoliasearch-client-php/lib/Configuration/ConfigWithRegion.php
Outdated
Show resolved
Hide resolved
millotp
approved these changes
Feb 1, 2022
| ]; | ||
|
|
||
| public static function create($appId = null, $apiKey = null, $region = null) | ||
| public static function create($appId = null, $apiKey = null, $region = null, $allowedRegions = null) |
There was a problem hiding this comment.
You could store the allowedRegions in the object to check against later in the setRegion method
There was a problem hiding this comment.
Actually you can't because create() is a static method. But anyways, I just saw that setRegion() is not used anywhere
millotp
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-273
Changes included: