chore: check if generated CTS match committed CTS #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Jan 31, 2022
shortcuts
reviewed
Feb 2, 2022
tests/CTS/config.json
Outdated
Comment on lines
1
to
10
| { | ||
| "javascript": { | ||
| "extension": "test.ts", | ||
| "outputFolder": "tests" | ||
| }, | ||
| "java": { | ||
| "extension": "test.java", | ||
| "outputFolder": "src/test/java/com/algolia" | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing formatting? It should be:
{
"javascript": {
"extension": "test.ts",
"outputFolder": "tests"
},
"java": {
"extension": "test.java",
"outputFolder": "src/test/java/com/algolia"
}
}
tests/src/utils.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export function outputPath({ |
There was a problem hiding this comment.
Suggested change
| export function outputPath({ | |
| export function getOutputPath({ |
Otherwise it feels like it's a variable name
|
Good idea :D |
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
To make sure the CTS was correctly generated, we check the git diff after generation, and fail if not correct.
Also harmonize the output path into utils to remove hardcoded path.