feat(specs): add appropriate type to model instance type property #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
francoischalifour
previously approved these changes
Oct 13, 2022
francoischalifour
approved these changes
Oct 17, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 3, 2022
algolia/api-clients-automation#1077 Co-authored-by: Adewusi Victor <glove.adewusi@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Nov 3, 2022
algolia/api-clients-automation#1077 Co-authored-by: Adewusi Victor <glove.adewusi@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Nov 3, 2022
algolia/api-clients-automation#1077 Co-authored-by: Adewusi Victor <glove.adewusi@gmail.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
typevaluePlease find spec here
modelIDandmetricsas required attributes in model metrics responsePlease find spec here
Changes included:
type) fromstringtoenummodelIDandmetricsas required attributes in model metrics response🧪 Test
CTS tests remain unchanged