Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): Algolia Search hostnames #1189

Merged
merged 1 commit into from
Dec 23, 2022
Merged

fix(specs): Algolia Search hostnames #1189

merged 1 commit into from
Dec 23, 2022

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Dec 20, 2022

🧭 What and Why

This PR fixes two hostnames in the Search API spec.
This brings the API spec in line with what's used by the API clients and what's in the current documentation.

🎟 JIRA Ticket: N/A

Changes included:

  • https://{appId}.algolianet.com -> https://{appId}.algolia.net
  • https://{appId}-dsn.algolianet.com -> https://{appId}-dsn.algolia.net

🧪 Test

N/A

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b1dd3e8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63a1fc1b5c9c6a000716464a
😎 Deploy Preview https://deploy-preview-1189--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 20, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 changed the title fix: Algolia Search hostnames fix(specs): Algolia Search hostnames Dec 20, 2022
@kai687 kai687 marked this pull request as ready for review December 20, 2022 18:22
@kai687 kai687 requested a review from a team as a code owner December 20, 2022 18:22
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks! indeed it's correct in the clients but not in the specs :D

@shortcuts shortcuts merged commit 377e091 into main Dec 23, 2022
@shortcuts shortcuts deleted the fix/algolia-hosts branch December 23, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants