Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): authenticationID is not required in source and destination #1203

Merged
merged 5 commits into from
Jan 11, 2023

Conversation

morganleroi
Copy link
Contributor

🧭 What and Why

The field authenticationID is not required in Source. For example, we can setup a new Source, without authentication setup.

Changes included:

  • Remove field from required

@morganleroi morganleroi requested a review from a team as a code owner December 29, 2022 09:06
@morganleroi morganleroi self-assigned this Dec 29, 2022
@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ed624bb
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63be9ab4b4fe9e000eebdd15
😎 Deploy Preview https://deploy-preview-1203--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@morganleroi morganleroi added the bug Something isn't working label Dec 29, 2022
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 29, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! and same for destination now, can you also add the change to this PR please?

@morganleroi morganleroi changed the title fix(specs): authenticationID is not required in source fix(specs): authenticationID is not required in source and destination Jan 10, 2023
@millotp millotp enabled auto-merge (squash) January 11, 2023 11:17
@millotp millotp merged commit 28d8260 into main Jan 11, 2023
@millotp millotp deleted the fix-source-required-fields branch January 11, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants