-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): numberOfPendingTasks is plural #1211
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks!
Yep indeed
As long as they are not required it should be interpreted correctly by the language, but it might make sense in some cases 🤔 I'd say it's worth adding them and see if it changes something to the generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
@kai687 will you try your 2nd question in this PR or can I merge? |
@shortcuts sorry, got side-tracked. |
no problem! |
This reverts commit e3e0aa5.
So, I guess making |
oops D: yep indeed it looks like |
Thanks again! |
🧭 What and Why
This PR aims to improve the specs for the
listIndicesResponse
schema.Testing the
/1/indexes
endpoint, I found thatnumberOfPendingTasks
should be plural.This PR also adds default values for
pendingTask
(false
) andnumberOfPendingTasks
(0
) as both values always seem to be part of the response.🎟 JIRA Ticket: N/A
Changes included:
numberOfPendingTasks
numberOfPendingTasks
andpendingTask
numberOfPendingTasks
required forlistIndicesResponse
primary
andreplicas
nullable🧪 Test