Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): remove content attributes from models [PRED-982] #1226

Merged
merged 2 commits into from
Feb 13, 2023
Merged

feat(specs): remove content attributes from models [PRED-982] #1226

merged 2 commits into from
Feb 13, 2023

Conversation

bengreenbank
Copy link
Contributor

@bengreenbank bengreenbank commented Jan 9, 2023 •
edited
Loading

Important

Do not merge until the changes are live in the production API.

🧭 What and Why

Remove contentAttributes from Predict specs.

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/PRED-982

Changes included:

  • Remove contentAttributes from models methods

🧪 Test

n/a

@bengreenbank bengreenbank self-assigned this Jan 9, 2023
@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 604f179
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63ea13f3e68aec000811f3c6
😎 Deploy Preview https://deploy-preview-1226--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 9, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@bengreenbank bengreenbank marked this pull request as ready for review January 9, 2023 10:30
@bengreenbank bengreenbank requested a review from a team as a code owner January 9, 2023 10:30
@shortcuts
Copy link
Member

feel free to ping when we need to merge/release :)

shortcuts
shortcuts approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@shortcuts shortcuts enabled auto-merge (squash) February 13, 2023 10:42
@shortcuts shortcuts merged commit bad1107 into main Feb 13, 2023
@shortcuts shortcuts deleted the feat/predict/remove_content_attrs branch February 13, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@writeens writeens writeens approved these changes

@shortcuts shortcuts shortcuts approved these changes

@francoischalifour francoischalifour francoischalifour approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@bengreenbank bengreenbank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bengreenbank @algolia-bot @shortcuts @francoischalifour @writeens