Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): remove input from auth list #1229

Merged
merged 3 commits into from
Jan 13, 2023
Merged

fix(specs): remove input from auth list #1229

merged 3 commits into from
Jan 13, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 11, 2023 •
edited
Loading

🧭 What and Why

The auth list endpoint doesn't return the input field.
Fixed the description for locales.
Make scope not required.

@millotp millotp self-assigned this Jan 11, 2023
@millotp millotp requested a review from a team as a code owner January 11, 2023 15:49
@netlify
Copy link

netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 822e79f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63bee52f8a1829000882a52c
😎 Deploy Preview https://deploy-preview-1229--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 11, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

damcou
damcou previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

shortcuts
shortcuts previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@millotp millotp enabled auto-merge (squash) January 11, 2023 15:52
@millotp millotp disabled auto-merge January 11, 2023 15:53
@millotp millotp dismissed stale reviews from shortcuts and damcou via edd4baa January 11, 2023 15:55
@millotp millotp enabled auto-merge (squash) January 11, 2023 17:35
Fluf22
Fluf22 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

shortcuts
shortcuts approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snobbé @Fluf22

@millotp millotp merged commit 466cc0b into main Jan 13, 2023
@millotp millotp deleted the fix/auth-input branch January 13, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@Fluf22 Fluf22 Fluf22 approved these changes

@damcou damcou Awaiting requested review from damcou

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@millotp @algolia-bot @damcou @Fluf22 @shortcuts