fix(javascript): auth via query parameters #124

shortcuts · 2022-02-08T10:22:06Z

🧭 What and Why

🎟 JIRA Ticket: -

Fix: auth via queryParameters were not passed
Feat: auth are now passed at the transporter initialization, instead of query time.
- This adds a baseQueryParameters option to the transporter

CI :D

millotp

Nice ! We should start adding test for those thing if the test platform is capable enough

shortcuts · 2022-02-08T10:34:27Z

Nice ! We should start adding test for those thing if the test platform is capable enough

Definitely, I believe we could have client-specific tests on the repository of the client itself, as we might not be able to generate them 🤔

fix(javascript): auth via query parameters

7faa6ef

shortcuts self-assigned this Feb 8, 2022

Merge branch 'main' into fix/javascript-auth-query-params

d15c046

shortcuts marked this pull request as draft February 8, 2022 10:25

shortcuts requested review from a team and damcou and removed request for a team February 8, 2022 10:30

shortcuts marked this pull request as ready for review February 8, 2022 10:30

millotp approved these changes Feb 8, 2022

View reviewed changes

shortcuts merged commit 3c1feb6 into main Feb 8, 2022

shortcuts deleted the fix/javascript-auth-query-params branch February 8, 2022 10:36

eunjae-lee mentioned this pull request Feb 9, 2022

chore: release 2022-02-09 #126

Closed

2 tasks

eunjae-lee mentioned this pull request Mar 7, 2022

chore: release 2022-03-07 #236

Closed

4 tasks

shortcuts added a commit that referenced this pull request Apr 22, 2022

fix(javascript): auth via query parameters (#124)

fcbf773