Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): correct types for Tasks trigger #1279

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix(specs): correct types for Tasks trigger #1279

merged 1 commit into from
Feb 3, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

This PR fixes some wrong types on the Ingestion specs, and makes the definition closer to the real API.

🧪 Test

  • there's no test for this client.

@shortcuts shortcuts requested a review from Fluf22 February 3, 2023 08:38
@shortcuts shortcuts self-assigned this Feb 3, 2023
@shortcuts shortcuts requested a review from a team as a code owner February 3, 2023 08:38
@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ecf80e5
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63dcc805c2ec5f0008652e1a
😎 Deploy Preview https://deploy-preview-1279--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 3, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect 👍🏻

@shortcuts shortcuts enabled auto-merge (squash) February 3, 2023 09:14
@shortcuts shortcuts merged commit a1c7c24 into main Feb 3, 2023
@shortcuts shortcuts deleted the fix/ingestion-specs branch February 3, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @Fluf22