Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add CSV source #1301

Merged
merged 6 commits into from
Feb 8, 2023
Merged

feat(specs): add CSV source #1301

merged 6 commits into from
Feb 8, 2023

Conversation

morganleroi
Copy link
Contributor

🧭 What and Why

Add CSV Source for Data Ingestion client API.

Changes included:

Add CSV to Source type.

@morganleroi morganleroi requested a review from a team as a code owner February 7, 2023 20:37
@netlify
Copy link

netlify bot commented Feb 7, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 52ca788
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63e35f29bb84cc0008eb4ea3
😎 Deploy Preview https://deploy-preview-1301--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@morganleroi morganleroi self-assigned this Feb 7, 2023
@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 7, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems 👌🏻

millotp
millotp reviewed Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
millotp
millotp reviewed Feb 8, 2023
View reviewed changes
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
millotp
millotp approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG !

@morganleroi
Copy link
Contributor Author

Could you allow me to merge PR in this repo @millotp ?

@morganleroi morganleroi merged commit b9b4ba3 into main Feb 8, 2023
@morganleroi morganleroi deleted the csv-source branch February 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts left review comments

@millotp millotp millotp approved these changes

@Fluf22 Fluf22 Fluf22 left review comments

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok mehmetaligok is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@morganleroi morganleroi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morganleroi @algolia-bot @Fluf22 @millotp @shortcuts