-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(javascript): monorepo #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Sorry for the unrelated |
shortcuts
force-pushed
the
feat/javascript-client-monorepo
branch
from
February 10, 2022 14:57
9389cf4
to
6a75c0a
Compare
millotp
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing ! Almost ready to deploy
millotp
approved these changes
Feb 10, 2022
This was referenced Feb 18, 2022
This was referenced Feb 28, 2022
This was referenced Mar 22, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-307
Changes included:
This PR is the first step of https://algolia.atlassian.net/browse/APIC-232 but introduces many unreleated changes to the bundling.
As of now, our
algoliasearch-client-javascript
folder was just a folder-of-folders, it now hosts the same structure as the actual repo.packages/
folder.gitignore
and updatetsconfigs
to match global one.@algolia/client-common
from packages as it's a dependency.🧪 Test
CI :D