Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add UniqueIDColumn property to SourceJSON input #1333

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix(specs): add UniqueIDColumn property to SourceJSON input #1333

merged 1 commit into from
Feb 22, 2023

Conversation

mehmetaligok
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-851

Changes included:

  • UniqueIDColumn added to SourceJSON spec

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5dea2d8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63f5e7165231a20008e032df
😎 Deploy Preview https://deploy-preview-1333--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 22, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@mehmetaligok mehmetaligok marked this pull request as ready for review February 22, 2023 10:03
@mehmetaligok mehmetaligok requested a review from a team as a code owner February 22, 2023 10:03
Fluf22
Fluf22 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌🏻

shortcuts
shortcuts approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@shortcuts shortcuts merged commit e3aa6b2 into main Feb 22, 2023
@shortcuts shortcuts deleted the feat/add-unique-id-to-json-source-spec branch February 22, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@Fluf22 Fluf22 Fluf22 approved these changes

@aallam aallam Awaiting requested review from aallam aallam is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mehmetaligok @algolia-bot @Fluf22 @shortcuts