chore(java): add api compat check #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compares the current generated code with the latest published version (snapshots included). Run with `./gradlew :api:japicmp`. In case on an incompatibility, the build will fail. The report should be available under `api/build/reports`.
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Feb 23, 2023
shortcuts
reviewed
Feb 23, 2023
Yes, it shouldn't be included indeed, gradle should build the folder at runtime |
aallam
force-pushed
the
feat/java-api
branch
from
4f9f0b5
to
eb612b7
Compare
millotp
reviewed
Feb 23, 2023
aallam
changed the title
Yes indeed! especially for strongly typed languages! I know that similar ideas exists for other languages such as kotlin, go and rust. It is definitely worth to look more into this! |
millotp
approved these changes
Feb 27, 2023
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Feb 27, 2023
algolia/api-clients-automation#1335 Co-authored-by: Mouaad Aallam <Mouaad@Aallam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Compares the current generated code with the latest published version (snapshots included).
To public API check is done using japicmp-gradle-plugin.
In case on an incompatibility, the build will fail. The report should be available under
api/build/reports.🎟 JIRA Ticket: APIC-645
Changes included:
apipackage to Java API client:api:japicmp