Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): update affinity value type to accomodate booleans and numbers #1388

Merged
merged 2 commits into from
Mar 13, 2023
Merged

feat(specs): update affinity value type to accomodate booleans and numbers #1388

merged 2 commits into from
Mar 13, 2023

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Mar 9, 2023 •
edited
Loading

🧭 What and Why

Introducing support for numbers and booleans in the value property of the Affinity type

From

{
    name:string,
    value:string,
    probability:number
}

to

{
    name:string,
    value:string | number | boolean,
    probability:number
}

Changes included:

  • Add PredictionAffinityValue type

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fede2c2
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/640f22fb068f2000088d663e
😎 Deploy Preview https://deploy-preview-1388--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 9, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@writeens writeens marked this pull request as ready for review March 13, 2023 11:17
@writeens writeens requested a review from a team as a code owner March 13, 2023 11:17
millotp
millotp previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good !

@writeens writeens self-assigned this Mar 13, 2023
@shortcuts
Copy link
Member

(waiting for the gen before approving)

shortcuts
shortcuts approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@shortcuts shortcuts merged commit 79ae980 into main Mar 13, 2023
@shortcuts shortcuts deleted the feat/predict/affinity-value-type branch March 13, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@francoischalifour francoischalifour francoischalifour approved these changes

@millotp millotp millotp left review comments

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@writeens writeens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@writeens @algolia-bot @shortcuts @francoischalifour @millotp