feat(clients): add Kotlin API client #1400

aallam · 2023-03-14T10:05:14Z

🧭 What and Why

Generation of Kotlin API Client with the following specification:

Using Kotlin Multiplatform. First targets are JVM and iOS.
kotlinx.serialization for serialization.
Ktor client as HTTP client.

🎟 JIRA Ticket:

APIC-651
APIC-652

Changes included:

netlify · 2023-03-14T10:05:22Z

✅ Deploy Preview for api-clients-automation ready!

Name	Link
🔨 Latest commit	`36013ca`
🔍 Latest deploy log	https://app.netlify.com/sites/api-clients-automation/deploys/6453c18b7790570008a87940
😎 Deploy Preview	https://deploy-preview-1400--api-clients-automation.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

algolia-bot · 2023-03-14T10:05:59Z

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp

looks really nice ! First pass on the form of the PR, there is too much to look at everything ahah, GG !

...iasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/configuration/Host.kt

...algoliasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/api/SearchApi.kt

tests/output/java/bin/test/com/algolia/methods/requests/SearchClientRequestsTests.class

config/generation.config.js

millotp

amazing work !

clients/algoliasearch-client-kotlin/client-bom/README.md

...s/algoliasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/BuildConfig.kt

...-kotlin/client/src/commonMain/kotlin/com/algolia/client/configuration/internal/HttpClient.kt

generators/gradle/wrapper/gradle-wrapper.properties

generators/src/main/java/com/algolia/codegen/AlgoliaKotlinGenerator.java

generators/src/main/java/com/algolia/codegen/cts/AlgoliaCTSGenerator.java

playground/kotlin/gradle/wrapper/gradle-wrapper.properties

playground/kotlin/bin/main/com/algolia/playground/Predict.kt

specs/abtesting/paths/abtests.yml

templates/kotlin/licenseInfo.mustache

millotp

Nice !
I think there is an issue with the CI, there is no code generated, can you try to bump the cache key pls ?

playground/kotlin/bin/main/com/algolia/playground/Recommend.kt

millotp · 2023-05-02T16:00:15Z

ah maybe it's not a cache key issue but a artifacts issue, we use them to pass file from jobs to jobs in the CI, you need to add one for kotlin in .github/actions/restore-artifacts/action.yml

Fluf22

Just a question following up @millotp remarks about versioning!

Otherwise, it looks really great!! Amazing work 🙌🏻

config/clients.config.json

shortcuts

This looks super clean, gg!

...client-kotlin/client/src/commonMain/kotlin/com/algolia/client/configuration/Configuration.kt

config/clients.config.json

shortcuts

Nothing to add on my side, SHIP IT!!

shortcuts

actually can you bump this value? https://github.com/algolia/api-clients-automation/blob/main/.github/.cache_version

so we get a full CI run

millotp · 2023-05-04T12:20:46Z

.github/actions/restore-artifacts/action.yml

+
+    # Kotlin
+    - name: Download clients-kotlin artifact
+      if: ${{ inputs.kotlin == 'true' && inputs.type == 'all' }}


can you add kotlin: true in main.yml where we call restore-artifacts pls ? otherwise this is ignored

millotp

i'm sorry I didn't except the CI to be that complicated, maybe it's easier if you make it work in another PR, this one is already huge and awesome, let's start with that !

To make the CI push the generated code you need to edit the setRunVariables.ts file to export a RUN_GEN_KOTLIN var

aallam · 2023-05-04T14:49:33Z

@millotp Hopefully this time is the one 😅 otherwise I will make another PR for the CI

millotp

looks like there is still something missing, but I'm not sure what

Done

algolia/api-clients-automation#1400 Co-authored-by: Mouaad Aallam <Mouaad@Aallam.com>

aallam force-pushed the feat/kotlin branch 3 times, most recently from a1b05fa to ae4ae98 Compare March 14, 2023 11:20

aallam changed the title ~~feat: add Kotlin API client~~ feat(clients): add Kotlin API client Mar 14, 2023

aallam force-pushed the feat/kotlin branch 3 times, most recently from d5d1dc6 to 899db6e Compare March 14, 2023 14:46

millotp reviewed Mar 16, 2023

View reviewed changes

aallam force-pushed the feat/kotlin branch 5 times, most recently from e0cc2a1 to a68c7a3 Compare March 27, 2023 20:59

aallam force-pushed the feat/kotlin branch 2 times, most recently from 47d7508 to fe26fa4 Compare April 13, 2023 12:33

aallam marked this pull request as ready for review April 13, 2023 12:33

aallam requested a review from a team as a code owner April 13, 2023 12:33

aallam requested review from damcou, Fluf22 and millotp April 13, 2023 12:33

millotp reviewed Apr 19, 2023

View reviewed changes

aallam force-pushed the feat/kotlin branch 7 times, most recently from 4edd2c9 to f95ce1b Compare April 20, 2023 14:07

aallam force-pushed the feat/kotlin branch from bb7ae9d to 6e3c4a4 Compare May 2, 2023 07:57

oneof workaround for cts tests

27bd206

aallam added the Kotlin Issue related to Kotlin client label May 2, 2023

millotp reviewed May 2, 2023

View reviewed changes

playground/kotlin/bin/main/com/algolia/playground/Recommend.kt Outdated Show resolved Hide resolved

Fluf22 reviewed May 2, 2023

View reviewed changes

config/clients.config.json Show resolved Hide resolved

shortcuts reviewed May 2, 2023

View reviewed changes

...client-kotlin/client/src/commonMain/kotlin/com/algolia/client/configuration/Configuration.kt Outdated Show resolved Hide resolved

config/clients.config.json Show resolved Hide resolved

aallam added 2 commits May 4, 2023 10:49

add kotlin to the ci's artifacts

e4b91cf

refact: use Duration for timeouts

a0c9c8e

aallam force-pushed the feat/kotlin branch from 70a9987 to a0c9c8e Compare May 4, 2023 08:58

Merge branch 'main' into feat/kotlin

e819680

aallam requested review from shortcuts and millotp May 4, 2023 10:09

shortcuts approved these changes May 4, 2023

View reviewed changes

shortcuts previously requested changes May 4, 2023

View reviewed changes

increase cache version

c1b5e13

aallam requested a review from shortcuts May 4, 2023 12:05

millotp reviewed May 4, 2023

View reviewed changes

update ci actions

c70a06c

aallam force-pushed the feat/kotlin branch from a39286d to c70a06c Compare May 4, 2023 12:49

millotp previously approved these changes May 4, 2023

View reviewed changes

add kotlin constant to setRunVariables.ts

36013ca

aallam dismissed millotp’s stale review via 36013ca May 4, 2023 14:30

millotp approved these changes May 4, 2023

View reviewed changes

aallam enabled auto-merge (squash) May 4, 2023 14:55

aallam merged commit 558b8fb into main May 4, 2023

aallam deleted the feat/kotlin branch May 4, 2023 14:56

algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request May 4, 2023

feat(clients): add Kotlin API client

c24e850

algolia/api-clients-automation#1400 Co-authored-by: Mouaad Aallam <Mouaad@Aallam.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(clients): add Kotlin API client #1400

feat(clients): add Kotlin API client #1400

aallam commented Mar 14, 2023 •

edited

Loading

netlify bot commented Mar 14, 2023 •

edited

Loading

algolia-bot commented Mar 14, 2023 •

edited

Loading

millotp left a comment

millotp left a comment

millotp left a comment

millotp commented May 2, 2023

Fluf22 left a comment

shortcuts left a comment

shortcuts left a comment

shortcuts left a comment

millotp May 4, 2023

aallam May 4, 2023

millotp left a comment

aallam commented May 4, 2023

millotp left a comment •

edited

Loading

feat(clients): add Kotlin API client #1400

feat(clients): add Kotlin API client #1400

Conversation

aallam commented Mar 14, 2023 • edited Loading

🧭 What and Why

Changes included:

netlify bot commented Mar 14, 2023 • edited Loading

✅ Deploy Preview for api-clients-automation ready!

algolia-bot commented Mar 14, 2023 • edited Loading

✗ The generated branch has been deleted.

millotp left a comment

Choose a reason for hiding this comment

millotp left a comment

Choose a reason for hiding this comment

millotp left a comment

Choose a reason for hiding this comment

millotp commented May 2, 2023

Fluf22 left a comment

Choose a reason for hiding this comment

shortcuts left a comment

Choose a reason for hiding this comment

shortcuts left a comment

Choose a reason for hiding this comment

shortcuts left a comment

Choose a reason for hiding this comment

millotp May 4, 2023

Choose a reason for hiding this comment

aallam May 4, 2023

Choose a reason for hiding this comment

millotp left a comment

Choose a reason for hiding this comment

aallam commented May 4, 2023

millotp left a comment • edited Loading

Choose a reason for hiding this comment

aallam commented Mar 14, 2023 •

edited

Loading

netlify bot commented Mar 14, 2023 •

edited

Loading

algolia-bot commented Mar 14, 2023 •

edited

Loading

millotp left a comment •

edited

Loading