Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add customRequest to ingestion and small fix #1418

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix(specs): add customRequest to ingestion and small fix #1418

merged 1 commit into from
Mar 22, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 22, 2023

🧭 What and Why

  • Fix the tasks.trigger property
  • Rename on_demand to onDemand
  • Add the 4 custom requests

@millotp millotp self-assigned this Mar 22, 2023
@millotp millotp requested a review from a team as a code owner March 22, 2023 14:27
@millotp millotp requested review from morganleroi and mehmetaligok and removed request for a team March 22, 2023 14:27
@netlify
Copy link

netlify bot commented Mar 22, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit f70f5a7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/641b2993d6f0f10008e84892
😎 Deploy Preview https://deploy-preview-1418--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 22, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find!

mehmetaligok
mehmetaligok previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mehmetaligok mehmetaligok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I asked a question to understand a use-case.

specs/ingestion/spec.yml Show resolved Hide resolved
Base automatically changed from fix/error-reporting to main March 22, 2023 16:14
@millotp millotp dismissed stale reviews from mehmetaligok and shortcuts via f70f5a7 March 22, 2023 16:15
@millotp millotp requested a review from shortcuts March 22, 2023 16:29
@millotp millotp enabled auto-merge (squash) March 22, 2023 16:30
@millotp
Copy link
Collaborator Author

millotp commented Mar 22, 2023

sorry for the double review I never know how to handle stack PR

@millotp millotp merged commit c49b6e6 into main Mar 22, 2023
@millotp millotp deleted the fix/ingestion-spec branch March 22, 2023 16:50
@shortcuts
Copy link
Member

sorry for the double review I never know how to handle stack PR

the rebase requires a force push so a new review, but you can merge -Xours when on the branch and it should resolve conflicts

@millotp
Copy link
Collaborator Author

millotp commented Mar 22, 2023

okay let me try on the next one, thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millotp @algolia-bot @shortcuts @mehmetaligok