Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add size to predict segment response #1434

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

bengreenbank
Copy link
Contributor

@bengreenbank bengreenbank commented Mar 31, 2023

🧭 What and Why

🎟 JIRA Ticket: PRED-1277

Changes included:

  • Adds size integer field to segment response. Includes the number of users that belong to the segment.

🧪 Test

n/a

@bengreenbank bengreenbank self-assigned this Mar 31, 2023
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ec71bb8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/643e788096f3710007808cfb
😎 Deploy Preview https://deploy-preview-1434--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 31, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@bengreenbank bengreenbank marked this pull request as ready for review April 18, 2023 10:12
@bengreenbank bengreenbank requested a review from a team as a code owner April 18, 2023 10:12
writeens
writeens previously approved these changes Apr 18, 2023
segmentSize:
type: number
format: int64
description: The number of users that match the segment conditions when it was created, last updated, or when model inference last ran.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an approximation or an accurate number? If it's an approximation, we could mention it to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@shortcuts shortcuts enabled auto-merge (squash) April 18, 2023 11:01
@shortcuts shortcuts merged commit 9a65a53 into main Apr 18, 2023
@shortcuts shortcuts deleted the feat/predict/segment-size branch April 18, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants