Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add property to BigQuery source input #1547

Merged
merged 1 commit into from
May 16, 2023
Merged

feat(specs): add property to BigQuery source input #1547

merged 1 commit into from
May 16, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented May 16, 2023 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1276

Changes included:

  • add customSQLRequest property to the BigQuery source input

@Fluf22 Fluf22 requested a review from a team as a code owner May 16, 2023 12:41
@Fluf22 Fluf22 self-assigned this May 16, 2023
@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 184e7f8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/646379e353c7f400084966cc
😎 Deploy Preview https://deploy-preview-1547--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 16, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@Fluf22 Fluf22 merged commit 49b4c00 into main May 16, 2023
@Fluf22 Fluf22 deleted the fix/bigquery-source-input branch May 16, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @shortcuts