Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add task input for bigquery #1549

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented May 16, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1104

Changes included:

  • add OnDemandDateUtilsInput for onDemand tasks linked to a bigquery source
  • add ScheduleDateUtilsInput for schedule tasks linked to a bigquery source

@Fluf22 Fluf22 requested a review from a team as a code owner May 16, 2023 14:13
@Fluf22 Fluf22 requested review from damcou and millotp May 16, 2023 14:13
@Fluf22 Fluf22 self-assigned this May 16, 2023
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 925a155
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/646738fc4f845000085b17b4
😎 Deploy Preview https://deploy-preview-1549--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 16, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

specs/ingestion/common/schemas/task.yml Outdated Show resolved Hide resolved
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
@Fluf22
Copy link
Contributor Author

Fluf22 commented May 19, 2023

@millotp @shortcuts do OpenAPI supports conditional ref?
Otherwise, I thought we could iterate on that to enforce type higher in the chain, with the trigger type discriminating between both task types.

In the meantime, I thought this was enough ☺️

@shortcuts
Copy link
Member

@millotp @shortcuts do OpenAPI supports conditional ref? Otherwise, I thought we could iterate on that to enforce type higher in the chain, with the trigger type discriminating between both task types.

That's what we've done in the other specs, e.g. recommend have the whole object of the query as a oneOf, where the enum is the discriminator. It's indeed ideal, but for now since the specs is in early stage it's fine to have looser type and refine later before going out of alpha I believe

@Fluf22 Fluf22 enabled auto-merge (squash) May 19, 2023 08:53
@Fluf22 Fluf22 merged commit 6284a8b into main May 19, 2023
@Fluf22 Fluf22 deleted the feat/bigquery-task-inputs branch May 19, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants