-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add task input for bigquery #1549
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
@millotp @shortcuts do OpenAPI supports conditional ref? In the meantime, I thought this was enough |
That's what we've done in the other specs, e.g. recommend have the whole object of the query as a oneOf, where the enum is the discriminator. It's indeed ideal, but for now since the specs is in early stage it's fine to have looser type and refine later before going out of alpha I believe |
🧭 What and Why
🎟 JIRA Ticket: DI-1104
Changes included:
OnDemandDateUtilsInput
foronDemand
tasks linked to abigquery
sourceScheduleDateUtilsInput
forschedule
tasks linked to abigquery
source