Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add objectID to BQ source input #1575

Merged
merged 1 commit into from
May 31, 2023
Merged

feat(specs): add objectID to BQ source input #1575

merged 1 commit into from
May 31, 2023

Conversation

damcou
Copy link
Contributor

@damcou damcou commented May 30, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1290

Changes included:

  • add objectID to BQ source input

@damcou damcou requested a review from shortcuts May 30, 2023 13:08
@damcou damcou self-assigned this May 30, 2023
@damcou damcou requested a review from a team as a code owner May 30, 2023 13:08
@damcou damcou requested a review from mehmetaligok May 30, 2023 13:08
@netlify
Copy link

netlify bot commented May 30, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 56ac42c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6475f55b45910700084454ec
😎 Deploy Preview https://deploy-preview-1575--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 30, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts reviewed May 30, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can draft it until it's implemented in our API

@damcou damcou changed the title feat(ingestion): add objectID to BQ source input feat(specs): add objectID to BQ source input May 30, 2023
@damcou damcou marked this pull request as draft May 30, 2023 13:13
@damcou damcou marked this pull request as ready for review May 31, 2023 11:59
@damcou damcou requested a review from shortcuts May 31, 2023 11:59
@damcou damcou merged commit 2a55abf into main May 31, 2023
@damcou damcou deleted the feat/DI-1290/update-bq-source branch May 31, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok mehmetaligok is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damcou @algolia-bot @shortcuts