Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add blocking to reasonCode instead of outcome #1622

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(specs): add blocking to reasonCode instead of outcome #1622

merged 2 commits into from
Jun 15, 2023

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jun 15, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1351

Changes included:

  • blocking value should belong to possible reasonCode and not RunOutcome

@damcou damcou requested a review from a team as a code owner June 15, 2023 16:15
@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b248bd0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/648b392c1fa2040008160949
😎 Deploy Preview https://deploy-preview-1622--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@damcou damcou requested a review from millotp June 15, 2023 16:15
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@millotp millotp merged commit 308c7cc into main Jun 15, 2023
@millotp millotp deleted the fix/DI-1351/update-reason-code branch June 15, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok mehmetaligok is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damcou @algolia-bot @millotp