Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): facet stats properties as double #1694

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix(specs): facet stats properties as double #1694

merged 2 commits into from
Jul 6, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 5, 2023

🧭 What and Why

Facets stats properties are defined as integers, but should be floating numbers.

Changes included:

Change the type of the following facets stats properties (max, min, avg and sum)

@netlify
Copy link

netlify bot commented Jul 5, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 939254f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64a66c0e3ae2a2000805997a
😎 Deploy Preview https://deploy-preview-1694--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 5, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aallam aallam marked this pull request as ready for review July 5, 2023 18:45
@aallam aallam requested a review from a team as a code owner July 5, 2023 18:45
@aallam aallam requested review from Fluf22 and millotp July 5, 2023 18:45
shortcuts
shortcuts reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I'm impressed Java passes, IIRC we had an issue with double, can you bump the cache key just to make sure we have a full CI run?

great find otherwise!

@aallam aallam requested a review from shortcuts July 6, 2023 07:24
@aallam aallam enabled auto-merge (squash) July 6, 2023 07:43
shortcuts
shortcuts approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that's insane then 🤔

@aallam aallam merged commit dc0ff04 into main Jul 6, 2023
@aallam aallam deleted the fix/search-facets-stats branch July 6, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aallam @algolia-bot @shortcuts