Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): unused imports in go tests #1719

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

unused imports aren't removed, and as the linter is not fully setup yet, let's quickly unlock pending PRs (#1683) . I've created https://algolia.atlassian.net/browse/DI-1417 for next sprint

Also fix the PATH so that it uses the same command everywhere, useful when using sh directly

@shortcuts shortcuts requested a review from a team as a code owner July 10, 2023 12:05
@shortcuts shortcuts self-assigned this Jul 10, 2023
@shortcuts shortcuts requested review from damcou and aallam July 10, 2023 12:05
@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 7ef5bb4
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64abf40ee3ab76000889c2a0
😎 Deploy Preview https://deploy-preview-1719--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shortcuts shortcuts changed the title fix: unused imports in go tests fix(scripts): unused imports in go tests Jul 10, 2023
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 10, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts enabled auto-merge (squash) July 10, 2023 12:09
@shortcuts shortcuts merged commit 27e2a8e into main Jul 10, 2023
@shortcuts shortcuts deleted the fix/go-test-format branch July 10, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants