Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): query suggestions #1740

Merged
merged 13 commits into from
Jul 19, 2023
Merged

feat(specs): query suggestions #1740

merged 13 commits into from
Jul 19, 2023

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jul 12, 2023 •
edited by jira bot
Loading

🧭 What and Why

This PR provides an update to the Query Suggestions API spec.

WIP: yarn docker generate fails now because:

-attribute components.schemas.SourceIndex.default is not of type `array`
-attribute components.schemas.QuerySuggestionsConfiguration.default is not of type `array`

🎟 JIRA Ticket: DOC-1111

@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a2857fa
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b7ddaf6aba4e0008b00bd9
😎 Deploy Preview https://deploy-preview-1740--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 12, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 marked this pull request as ready for review July 13, 2023 10:56
@kai687 kai687 requested a review from a team as a code owner July 13, 2023 10:56
@kai687 kai687 requested review from Fluf22 and millotp July 13, 2023 10:56
@shortcuts shortcuts changed the title docs(specs): query suggestions feat(specs): query suggestions Jul 19, 2023
shortcuts
shortcuts previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely!

@shortcuts shortcuts enabled auto-merge (squash) July 19, 2023 12:57
@shortcuts shortcuts merged commit 333368a into main Jul 19, 2023
@shortcuts shortcuts deleted the feat/specs/qs branch July 19, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kai687 @algolia-bot @shortcuts