Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine renovate config #1747

Merged
merged 2 commits into from
Jul 13, 2023
Merged

chore: refine renovate config #1747

merged 2 commits into from
Jul 13, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 13, 2023

🧭 What and Why

Using renovate locally I was able to make sure all 1926 versions we have in our monorepo are either tracked by renovate, or generated, for a total of of 373 tracked dependencies in 82 files !

@millotp millotp requested a review from a team as a code owner July 13, 2023 15:05
@millotp millotp self-assigned this Jul 13, 2023
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6f64d51
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b012c44fd0b600086e19bc
😎 Deploy Preview https://deploy-preview-1747--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 13, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS HUGE

renovate.json Show resolved Hide resolved
"fileMatch": [
"\\.github/workflows/.*\\.ya?ml$"
]
},
"ignorePaths": [
"**/algoliasearch/**",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it allow negative patterns? maybe we can ignore everything in packages but the common ones

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no it's only glob, not even regex, and the includePaths property doesn't work alongside it so we can't do like in generation.config.mjs

@millotp millotp requested a review from shortcuts July 13, 2023 15:10
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gg!!

@millotp millotp merged commit 9ef4bae into main Jul 13, 2023
@millotp millotp deleted the chore/refine-renovate branch July 13, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants