Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): esm release #1772

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(scripts): esm release #1772

merged 1 commit into from
Jul 18, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

See https://github.com/algolia/api-clients-automation/actions/runs/5584120552/jobs/10205172965, it seems like I forgot to convert the release script to esm.

Also use --env-file instead of inline env for the release, so that it matches what we recommend in the release process

@shortcuts shortcuts requested a review from a team as a code owner July 18, 2023 09:44
@shortcuts shortcuts self-assigned this Jul 18, 2023
@shortcuts shortcuts requested review from Fluf22 and millotp July 18, 2023 09:44
@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 925f2fe
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b65efb32586e0008242fde
😎 Deploy Preview https://deploy-preview-1772--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 18, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this will cause issues with our IDEs 😂

@shortcuts
Copy link
Member Author

I feel like this will cause issues with our IDEs 😂

idk why they made esm usage so complicated 🤷🏻

@shortcuts shortcuts enabled auto-merge (squash) July 18, 2023 09:56
@shortcuts shortcuts merged commit 459eaaf into main Jul 18, 2023
@shortcuts shortcuts deleted the fix/release-script branch July 18, 2023 09:58
@algolia-bot algolia-bot mentioned this pull request Jul 18, 2023
Closed
This was referenced Jul 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @Fluf22