Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): bump version to beta.1 #1863

Merged
merged 3 commits into from
Aug 3, 2023
Merged

feat(java): bump version to beta.1 #1863

merged 3 commits into from
Aug 3, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 3, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-1441

Bump java version to beta.0 !
And merge the changelog to this version

@millotp millotp self-assigned this Aug 3, 2023
@millotp millotp requested a review from a team as a code owner August 3, 2023 12:42
@millotp millotp requested review from aallam and Fluf22 August 3, 2023 12:42
@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 36f023c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64cbba24a460ee00085ddec8
😎 Deploy Preview https://deploy-preview-1863--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@@ -9,7 +9,7 @@ repositories {

dependencies {
implementation 'io.github.cdimascio:dotenv-java:3.0.0'
implementation 'com.algolia:algoliasearch-client-java:0.0.1-SNAPSHOT'
implementation 'com.algolia:algoliasearch-client-java:4.0.0-beta.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to start with beta 0 ? is this related to the release process ? if not, we can start directly with 1 !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we always begin version number at 0, at Algolia 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind changing to 1, it was written 0 in the ticket ahah

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I think we always start new versions at 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 1

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@shortcuts
Copy link
Member

can you update the PR title pls? so it's correct on the changelog @millotp

@millotp millotp changed the title feat(java): bump version to beta.0 feat(java): bump version to beta.1 Aug 3, 2023
@millotp millotp enabled auto-merge (squash) August 3, 2023 14:31
@millotp millotp merged commit 268f765 into main Aug 3, 2023
21 checks passed
@millotp millotp deleted the feat/java-beta branch August 3, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants