-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): bump version to beta.1 #1863
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
playground/java/build.gradle
Outdated
@@ -9,7 +9,7 @@ repositories { | |||
|
|||
dependencies { | |||
implementation 'io.github.cdimascio:dotenv-java:3.0.0' | |||
implementation 'com.algolia:algoliasearch-client-java:0.0.1-SNAPSHOT' | |||
implementation 'com.algolia:algoliasearch-client-java:4.0.0-beta.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to start with beta 0
? is this related to the release process ? if not, we can start directly with 1
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we always begin version number at 0, at Algolia 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind changing to 1, it was written 0 in the ticket ahah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I think we always start new versions at 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely
can you update the PR title pls? so it's correct on the changelog @millotp |
🧭 What and Why
🎟 JIRA Ticket: DI-1441
Bump java version to
beta.0
!And merge the changelog to this version