Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): optional/required query and params #1864

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Aug 3, 2023

🧭 What and Why

query and params are required for Search (and Browse), but not for Recommend

Changes included:

Set query and params as required for Search, and as optional for Recommend.

@aallam aallam requested a review from a team as a code owner August 3, 2023 13:09
@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 8d653ce
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64cbb02824337600086efff6
😎 Deploy Preview https://deploy-preview-1864--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aallam aallam enabled auto-merge (squash) August 3, 2023 13:12
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
@aallam aallam requested a review from shortcuts August 3, 2023 13:48
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great nice find!

@aallam aallam merged commit c6a7ab4 into main Aug 3, 2023
21 checks passed
@aallam aallam deleted the fix/recommend-response-required branch August 3, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants