-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): mixed SearchParams
and IndexSettings
#1889
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great ! so much code generated ahah
Yup I also took the opportunity to improve some types e.g. |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1469
Changes included:
reported by @DevinCodes and @Keylor42, some index settings differs from the Go v3 and v4 clients, this made me want to check every
IndexSettings
andSearchParams
we have to see where were the overlaps/mixed/issues.I took the JavaScript (settings, search params) and Go (settings, search params) clients to do so, and the API reference to double check everything.
also update the CTS to run tests againsts:
setSettings
search