Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): mixed SearchParams and IndexSettings #1889

Merged
merged 10 commits into from
Aug 9, 2023
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 8, 2023

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1469

Changes included:

reported by @DevinCodes and @Keylor42, some index settings differs from the Go v3 and v4 clients, this made me want to check every IndexSettings and SearchParams we have to see where were the overlaps/mixed/issues.

I took the JavaScript (settings, search params) and Go (settings, search params) clients to do so, and the API reference to double check everything.

also update the CTS to run tests againsts:

  • every existing parameters for setSettings
  • every existing parameters for search

@shortcuts shortcuts self-assigned this Aug 8, 2023
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 21d8629
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64d26a8d958d7800086821e0
😎 Deploy Preview https://deploy-preview-1889--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 8, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review August 8, 2023 15:56
@shortcuts shortcuts requested a review from a team as a code owner August 8, 2023 15:56
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! so much code generated ahah

@shortcuts
Copy link
Member Author

looks great ! so much code generated ahah

Yup I also took the opportunity to improve some types e.g. IndexSettingsAsSearchParamsSemanticSearch was a bit... java-esque to type, SemanticSearch is easier ahah

@shortcuts shortcuts merged commit 5a9d949 into main Aug 9, 2023
@shortcuts shortcuts deleted the fix/search-specs branch August 9, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants