Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add inference ACL to API key object #1985

Merged
merged 1 commit into from
Sep 6, 2023
Merged

feat(specs): add inference ACL to API key object #1985

merged 1 commit into from
Sep 6, 2023

Conversation

helenamariano
Copy link
Contributor

@helenamariano helenamariano commented Sep 6, 2023 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket:
AIE-512

The 1/keys endpoint supports the inference ACL and has been deployed to production. See SRCH-6617. This change updates clients accordingly.

Changes included:

  • Add inference ACL option

🧪 Test

run cts tests

@netlify
Copy link

netlify bot commented Sep 6, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 0d47324
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64f7d4c44406cb0008a59dd3
😎 Deploy Preview https://deploy-preview-1985--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 6, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@helenamariano helenamariano marked this pull request as ready for review September 6, 2023 01:33
@helenamariano helenamariano requested a review from a team as a code owner September 6, 2023 01:33
@helenamariano helenamariano requested review from aallam and morganleroi and removed request for jkaho September 6, 2023 01:33
millotp
millotp approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! is this ready to be released ?

@helenamariano
Copy link
Contributor Author

thanks ! is this ready to be released ?

Yes it is ready

@millotp millotp merged commit 1381b70 into main Sep 6, 2023
22 checks passed
@millotp millotp deleted the AIE-512/spec_apikey_inference_acl branch September 6, 2023 07:29
@helenamariano helenamariano mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@aallam aallam Awaiting requested review from aallam aallam is a code owner automatically assigned from algolia/api-clients-automation

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helenamariano @algolia-bot @millotp