Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add recordType and fallbackIsInStockValue in inputs #1988

Merged
merged 4 commits into from
Sep 7, 2023
Merged

feat(specs): add recordType and fallbackIsInStockValue in inputs #1988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3acdfc8
feat(ingestion): add missing properties for source and destination in…
damcou Sep 7, 2023
b4645a5
typo
damcou Sep 7, 2023
69a1e2d
lint specs omg
damcou Sep 7, 2023
96bfbf4
update cache version
damcou Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.cache_version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.0.94
0.0.95
9 changes: 8 additions & 1 deletion specs/ingestion/common/schemas/destination.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ DestinationCreateResponse:
DestinationUpdate:
type: object
additionalProperties: false
description: Payload to partialy update a Destination.
description: Payload to partially update a Destination.
properties:
type:
$ref: '#/DestinationType'
Expand Down Expand Up @@ -122,9 +122,16 @@ DestinationIndexName:
indexName:
type: string
description: The index name to store data in.
recordType:
$ref: '#/RecordType'
required:
- indexName

RecordType:
type: string
description: Determines the indexing strategy to use for a given e-commerce source.
enum: [ 'product', 'variant' ]

DestinationInput:
oneOf:
- $ref: '#/DestinationIndexPrefix'
Expand Down
5 changes: 5 additions & 0 deletions specs/ingestion/common/schemas/source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ SourceCommercetools:
type: string
projectKey:
type: string
fallbackIsInStockValue:
type: boolean
default: true
description: >
Determines the value that will be stored in the Algolia record if there's no inventory information on the product.
required:
- url
- projectKey
Expand Down