Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): introduced SourceUpdateDocker #2005

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Sep 12, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

To improve clarity and code readability, the 'SourceDocker' was renamed to 'SourceUpdateDocker'. The required property 'configuration' was moved to SourceUpdateDocker, while the 'imageType' property now exists in both the SourceUpdateDocker and SourceDocker. In addition, SourceDocker now includes a reference to SourceUpdateDocker. These changes ensure a more logical and understandable schema structure.

@Fluf22 Fluf22 self-assigned this Sep 12, 2023
@Fluf22 Fluf22 requested a review from a team as a code owner September 12, 2023 13:45
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 31468b9
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65007ffc9890860008435cc9
😎 Deploy Preview https://deploy-preview-2005--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 12, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 changed the title fix: introduced SourceUpdateDocker fix(javascript): introduced SourceUpdateDocker Sep 12, 2023
@Fluf22
Copy link
Contributor Author

Fluf22 commented Sep 12, 2023

Let's see if the allOf works as expected 😇

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noicee

specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
@shortcuts shortcuts changed the title fix(javascript): introduced SourceUpdateDocker fix(specs): introduced SourceUpdateDocker Sep 12, 2023
To improve clarity and code readability, the 'SourceDocker' was renamed to 'SourceUpdateDocker'. The required property 'configuration' was moved to SourceUpdateDocker, while the 'imageType' property now exists in both the SourceUpdateDocker and SourceDocker. In addition, SourceDocker now includes a reference to SourceUpdateDocker. These changes ensure a more logical and understandable schema structure.
@Fluf22 Fluf22 force-pushed the fix/docker-source-outputfile branch from 54f8f7d to 0a7c7ba Compare September 12, 2023 15:08
@Fluf22
Copy link
Contributor Author

Fluf22 commented Sep 12, 2023

@shortcuts in the end, I made two different objects so I could control the required list of props.

@Fluf22 Fluf22 requested a review from shortcuts September 12, 2023 15:13
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, might be worth to share properties but up to you

@Fluf22 Fluf22 merged commit e73b9cf into main Sep 12, 2023
@Fluf22 Fluf22 deleted the fix/docker-source-outputfile branch September 12, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants