Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add attributesToExclude for Ingestion #2053

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1501

Changes included:

This PR adds the new attributesToExclude property to the Ingestion specs.

@shortcuts shortcuts self-assigned this Sep 28, 2023
@shortcuts shortcuts requested a review from a team as a code owner September 28, 2023 06:56
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit c8d7607
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/651523b099fedb000889bc55
😎 Deploy Preview https://deploy-preview-2053--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 28, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts
Copy link
Member Author

shortcuts commented Sep 28, 2023

we need to find a way to keep newlines in the code docs :( cc @aallam if you have any idea

@shortcuts shortcuts merged commit 2260e90 into main Sep 28, 2023
20 checks passed
@shortcuts shortcuts deleted the feat/specs-attributesToExclude branch September 28, 2023 07:07
@aallam
Copy link
Member

aallam commented Sep 28, 2023

we need to find a way to keep newlines in the code docs :( cc @aallam if you have any idea

@shortcuts for multi lines entries, I think using | (instead of >) keeps the newlines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants