Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): Remove attributeForDistinct from the indexSettingsAsSearc… #2078

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

clemfromspace
Copy link
Contributor

🧭 What and Why

attributeForDistinct is a settings-only parameter and shouldn't be present in the search / browse params.

@clemfromspace clemfromspace requested a review from a team as a code owner October 2, 2023 07:46
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4cdfb38
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/651a7575adb56000085f32a6
😎 Deploy Preview https://deploy-preview-2078--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 2, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@clemfromspace clemfromspace changed the title feat(specs) Remove attributeForDistinct from the indexSettingsAsSearc… feat(specs): Remove attributeForDistinct from the indexSettingsAsSearc… Oct 2, 2023
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@millotp millotp merged commit 756f19a into main Oct 2, 2023
23 of 24 checks passed
@millotp millotp deleted the feat/specs-attributeForDistinct branch October 2, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants