-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add new events type for insights #2080
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great on the generation side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor suggestions
specs/insights/common/schemas/AddedToCartObjectIDsAfterSearch.yml
Outdated
Show resolved
Hide resolved
specs/insights/common/schemas/PurchasedObjectIDsAfterSearch.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jessica <j.h_7@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg!!
🧭 What and Why
🎟 JIRA Ticket: APIC-716
Add the 4 new types of events for insights:
AddedToCartObjectIDs
AddedToCartObjectIDsAfterSearch
PurchasedObjectIDs
PurchasedObjectIDsAfterSearch