Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add new events type for insights #2080

Merged
merged 9 commits into from
Oct 4, 2023
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 4, 2023

🧭 What and Why

🎟 JIRA Ticket: APIC-716

Add the 4 new types of events for insights:

  • AddedToCartObjectIDs
  • AddedToCartObjectIDsAfterSearch
  • PurchasedObjectIDs
  • PurchasedObjectIDsAfterSearch

@millotp millotp requested a review from a team as a code owner October 4, 2023 10:07
@millotp millotp self-assigned this Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit c710e85
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/651d79cfa545ce0007b577ea
😎 Deploy Preview https://deploy-preview-2080--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 4, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts requested review from benhinchley and jkaho October 4, 2023 10:23
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great on the generation side!

specs/insights/common/enums.yml Outdated Show resolved Hide resolved
specs/insights/common/schemas/EventsItems.yml Show resolved Hide resolved
Copy link
Contributor

@jkaho jkaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestions

specs/insights/common/schemas/AddedToCartObjectIDs.yml Outdated Show resolved Hide resolved
specs/insights/common/schemas/AddedToCartObjectIDs.yml Outdated Show resolved Hide resolved
specs/insights/common/schemas/EventAttributes.yml Outdated Show resolved Hide resolved
specs/insights/common/schemas/EventAttributes.yml Outdated Show resolved Hide resolved
specs/insights/common/schemas/PurchasedObjectIDs.yml Outdated Show resolved Hide resolved
@millotp
Copy link
Collaborator Author

millotp commented Oct 4, 2023

Thanks for the review @jkaho, it should be resolved by e7d0152 😃

Co-authored-by: Jessica <j.h_7@yahoo.com>
@millotp millotp requested a review from jkaho October 4, 2023 14:31
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg!!

@millotp millotp merged commit d386191 into main Oct 4, 2023
20 checks passed
@millotp millotp deleted the feat/insight-events branch October 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants