Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): search insideBoundingBox and insidePolygon types #2098

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Oct 9, 2023

Changes included:

Update insideBoundingBox and insidePolygon types to a list of list of ints.

fixes #2097

@aallam aallam requested a review from a team as a code owner October 9, 2023 13:35
@aallam aallam requested review from Fluf22 and millotp October 9, 2023 13:35
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 775c671
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/652408bba99d9000087e9449
😎 Deploy Preview https://deploy-preview-2098--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 9, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@aallam aallam enabled auto-merge (squash) October 9, 2023 13:37
@aallam aallam changed the title fix(specs): search insideBoundingBox type fix(specs): search insideBoundingBox and insidePolygon types Oct 9, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!!

@aallam aallam merged commit f8e79a1 into main Oct 9, 2023
14 of 20 checks passed
@aallam aallam deleted the fix/inside-bounding-box branch October 9, 2023 14:11
@aallam
Copy link
Member Author

aallam commented Oct 9, 2023

Well, how this got merged before the CI passes !!!

@millotp
Copy link
Collaborator

millotp commented Oct 9, 2023

skipped CI are not required 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid value for \"insideBoundingBox\" parameter, expected float
5 participants